Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Public set methods for data bag #6

Merged
merged 1 commit into from
Jan 19, 2024
Merged

Conversation

marekfilip
Copy link
Contributor

It's very hard or almost impossible to create some tests if we can't define some data in the data bag, so I'm making it public.

It's very hard or almost impossible to create some tests if we can't
define some data in the data bag, so I'm making it public.
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4869c63) 99.08% compared to head (08ebaff) 99.08%.

❗ Current head 08ebaff differs from pull request most recent head 8e6052f. Consider uploading reports for the commit 8e6052f to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master       #6   +/-   ##
=======================================
  Coverage   99.08%   99.08%           
=======================================
  Files           5        5           
  Lines         219      219           
=======================================
  Hits          217      217           
  Misses          1        1           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@danikalmar danikalmar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@marekfilip marekfilip merged commit 63192e5 into master Jan 19, 2024
3 checks passed
@marekfilip marekfilip deleted the public-set-in-data-bag branch January 19, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants